From 7aeba400439ef59e8b90c059c452eada8b161978 Mon Sep 17 00:00:00 2001
From: Adrian Wannenmacher <tfld@tfld.dev>
Date: Mon, 9 Feb 2026 23:20:41 +0100
Subject: [PATCH] stop creating games on session creation

This is necessary to allow users to create new sessions with different
game point goals, and have that goal be in effect for the very first
game.
---
 models/session.js      |  1 -
 models/session.test.js | 15 ++++++++++++---
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/models/session.js b/models/session.js
index 04814ae..534a894 100644
--- a/models/session.js
+++ b/models/session.js
@@ -80,7 +80,6 @@ export default class Session {
 
   constructor(value) {
     if (value === undefined) {
-      this.anotherGame();
     } else if (typeof value === "object") {
       if (!("goal" in value))
         throw new TypeError("missing goal in deserialization object");
diff --git a/models/session.test.js b/models/session.test.js
index 5d7c45c..c841456 100644
--- a/models/session.test.js
+++ b/models/session.test.js
@@ -10,7 +10,7 @@ QUnit.module("models", function() {
       let session = new Session();
       assert.strictEqual(session.goal, 11, "initial goal");
       assert.strictEqual(session.games.length, 0, "no finished games");
-      assert.notStrictEqual(session.currentGame, null, "game in progress");
+      assert.strictEqual(session.currentGame, null, "no game in progress");
       assert.deepEqual(
         session.result,
         { ourPoints: 0, theirPoints: 0 },
@@ -19,8 +19,15 @@ QUnit.module("models", function() {
       assert.strictEqual(session.theirTeam, "", "their team name");
     });
 
+    QUnit.test("start game", function(assert) {
+      let session = new Session();
+      session.anotherGame();
+      assert.notStrictEqual(session.currentGame, null, "game in progress");
+    });
+
     QUnit.test("single game finished", function(assert) {
       let session = new Session();
+      session.anotherGame();
       session.currentGame.currentRound.winner = Team.We;
       for (let i = 0; i < session.goal; i += 2)
         session.currentGame.currentRound.winner = Team.They;
@@ -43,6 +50,7 @@ QUnit.module("models", function() {
 
     QUnit.test("two games finished", function(assert) {
       let session = new Session();
+      session.anotherGame();
       session.currentGame.currentRound.winner = Team.We;
       for (let i = 0; i < session.goal; i += 2)
         session.currentGame.currentRound.winner = Team.They;
@@ -68,6 +76,7 @@ QUnit.module("models", function() {
 
     QUnit.test("new game doesn't overwrite existing", function(assert) {
       let session = new Session();
+      session.anotherGame();
       session.currentGame.currentRound.winner = Team.We;
       assert.notStrictEqual(session.currentGame, null, "ongoing game");
 
@@ -86,7 +95,6 @@ QUnit.module("models", function() {
     QUnit.test("serialization - new session", function(assert) {
       let session = new Session();
       let json = session.toJSON();
-      json.currentGame = session.currentGame.toJSON();
 
       assert.deepEqual(
         json,
@@ -95,13 +103,14 @@ QUnit.module("models", function() {
           ourTeam: "",
           theirTeam: "",
           games: [],
-          currentGame: session.currentGame.toJSON()
+          currentGame: null,
         },
         "correct serialization");
     });
 
     QUnit.test("serialization - finished & unfinished game", function(assert) {
       let session = new Session();
+      session.anotherGame();
       session.currentGame.currentRound.winner = Team.We;
       for (
         let i = 0;